[git-buildpackage] [PATCH] setup.py: require dateutil

Ken Dreyer kdreyer at redhat.com
Wed Jul 5 19:25:24 CEST 2017


On Wed, Jul 5, 2017 at 11:10 AM, Guido Günther <agx at sigxcpu.org> wrote:
> Isn't using requirements.txt the right thing? We
> have this since some time.

I don't see newer packages using requirements.txt, but I am not a
Python expert :)

Here is the use-case I'm trying to support:

1. Create and activate a fresh virtualenv
2. pip install gpb
3. gbp pq

Actual results:
  'pq' is not a valid command.

Expected results:
  gbp recognizes the pq command

The problem is that python-dateutil is not present in my virtualenv
when I run "pip install gbp". It's the same when I run "python
setup.py install" directly from Git. I'd expect that these commands
would install the dependencies automatically.

When I run "pip install python-dateutil" by hand, it satisfies the
dependency, and gbp recognizes the pq command.

I think switching from requirements.txt to install_requires would
resolve this. What do you think?

- Ken


More information about the git-buildpackage mailing list