[git-buildpackage] Would it be possible for pristine-tar to not be an absolute path?

[Guido Günther]

Hi,
On Wed, Aug 30, 2017 at 09:37:28AM -0700, Nish Aravamudan wrote:
> Hello,
> 
> I am currently using gbp in a snap for `git-ubuntu`, a tool similar to
> dgit for doing Ubuntu source package work. The snap contains all its

Can you point me to the snap?

> dependencies, including pristine-tar at paths within the snap (which I
> ensure are in PATH when my tool runs), but gbp has a hard-coded path
> to pristine-tar:
> 
> gbp/pkg/pristinetar.py:
> ...
> class PristineTar(Command):
>     """The pristine-tar branch in a git repository"""
>     cmd = '/usr/bin/pristine-tar'
> 
> Is that strictly necessary for the way Command works? Would it be
> possible to allow the cli (since it may not be override-able
> otherwise) to specify where pristine-tar lives rather than it being
> hardcoded?

Is pristine-tar in your $PATH? As with subprocess when not going through
a shell we need an absolute path. I'm happy to add logic to check in
$PATH or different locations but I rather understand the problem first.
(I'd be great if we wouldn't need even more cli options).
Cheers,
 -- Guido

> 
> Thanks,
> Nish
> _______________________________________________
> git-buildpackage mailing list
> git-buildpackage at lists.sigxcpu.org
> http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage
>