[git-buildpackage] git-buildpackage-rpm patchset 2015-10-07

[Markus Lehtonen]

Hi Guido,

(cc'd the mailing list as it was unintentionally left out)

On Tue, 2015-10-20 at 08:49 +0200, Guido Günther wrote:
> Hi Markus,
> On Wed, Oct 07, 2015 at 05:23:37PM +0300, Markus Lehtonen wrote:
> > Hi Guido,
> > 
> > I'm sorry for the very long silence on my behalf. I have been terribly
> > busy elsewhere and didn't have enough time to devel into gbp with
> > thought.
> 
> No worries, I've not been too responsive either. Thanks a lot for
> having a look!
> 
> > First: thank you for merging buildpackage-rpm, that's great news! I must
> > apologize for not doing my job and addressing the issues in time.
> 
> Thank you for the code and all your patience!
> 
> > I finally rebased my branches and decided to send a short note. My
> > branch layout is still the same:
> >    experimental-rpm
> >    feature/argparse
> >    feature/buildpackage-rpm
> >    feature/fixes
> >    feature/import-srpm
> >    feature/misc
> >    feature/pq-rpm
> >    feature/python-pkg-resources
> > 
> > There is one new branch, i.e. feature/fixes, which is supposed to
> > contain straightforward (bug) fixes. You might want to take a look at
> > that at first. The feature/misc branch should contain less controversial
> > stuff, too (I hope).
> 
> I've pulled in all the fixes preparing for a 0.7.0 release, thanks!

OK, good.

I added one more patch to the feature/fixes branch. It fixes the FSF
addresses in the rest of the .py file comment headers.


> > Then, what do you think about 'feature/argparse' and
> > 'feature/python-pkg-resources', at least on general level? Is it worth
> > for me keeping them rebased/up-to-date?
> 
> I intend to have a look at the argparse code after finishing some other
> work in gbp import-orig. I think it's fine to leave the pkg-resources
> code as is for the moment since it's fine to get the ideas across and we
> can rebase once I looked at it in more detail.

Waiting for comments, then...


> > I will reply to you comments about the buildpackage-rpm patchset  (from
> > back in April!) in a later email.
> 
> I'll comment on these later on.
> 
> (not cc'ing the list since I figure you left it out by intention?).

No, I wrote the email in a hurry and forgot to cc the list.


Thanks,
  Markus