[git-buildpackage] [PATCH 01/11] common/buildpackage: support for different archive formats

[Markus Lehtonen]

On Tue, 2015-10-20 at 08:50 +0200, Guido Günther wrote:
> Hi Markus,
> On Thu, Oct 08, 2015 at 11:44:10AM +0300, Markus Lehtonen wrote:
> > Hi,
> > 
> > On 01/04/15 21:04, "Guido Günther" <agx at sigxcpu.org> wrote:
> > 
> > >I'll just use git-format-patch to format your series into patches and
> > >add the comments. Won't get far today but lets start.
> > >
> > >On Tue, May 15, 2012 at 04:37:33PM +0300, Markus Lehtonen wrote:
> > >> Adds support for defining the archive format of the output of
> > >> git_archive_single(), e.g. 'zip'. Defaults to 'tar', as before.
> > >> 
> > >> Signed-off-by: Ed Bartosh <eduard.bartosh at intel.com>
> > >> Signed-off-by: Markus Lehtonen <markus.lehtonen at linux.intel.com>
> > >> ---
> > >>  debian/control                     |  2 +-
> > >>  gbp/command_wrappers.py            | 10 ++++++++
> > >>  gbp/scripts/common/buildpackage.py | 48
> > >>++++++++++++++++++++++----------------
> > >>  3 files changed, 39 insertions(+), 21 deletions(-)
> > >> 
> > >> diff --git a/debian/control b/debian/control
> > >> index e679bdf..985b7d8 100644
> > >> --- a/debian/control
> > >> +++ b/debian/control
> > >> @@ -47,7 +47,7 @@ Depends: ${python:Depends},
> > >>   python-pkg-resources,
> > >>   python-six,
> > >>  Recommends: pristine-tar (>= 0.5), cowbuilder, python-requests
> > >> -Suggests: python-notify, unzip
> > >> +Suggests: python-notify, unzip, zipmerge
> > >
> > >Do we need this? Debian does not support zip as upstream tarball
> > >format. It might make sense on the rpm tools though.
> > 
> > RPM packages may use zip archive. I put the dependency here because the
> > new functionality touches the common parts of gbp. In practice though, the
> > zip format is only used by the rpm tools. Thus, the dependency could
> > probably be moved to git-buildpackage-rpm subpackage. Would you be ok with
> > this?
> 
> Yeah, that's fine.

Good! A fixed patch is available at my github repo:
  git://github.com/marquiz/git-buildpackage-rpm.git
feature/upstream/buildpackage-rpm


Thanks,
  Markus