[git-buildpackage] environment clearing?

[Guido Günther]

Hi Daniel,
On Wed, Nov 18, 2015 at 03:37:55PM -0500, Daniel Kahn Gillmor wrote:
> Almost:
> 
> buildpackage.builder is the empty string, but

And that is a bug in gbp itself since it should print the default value
here instead of the empty string. Fixed with:

    https://git.sigxcpu.org/cgit/git-buildpackage/commit/?id=6d802390e2274bc0c3d03623edac2eb8c482a829

> buildpackage.pbuilder=False
> 
> > If so, can you try to set the builder to a command that just dumps the
> > environment into a file like:
> >
> >     gbp buildpackage --git-builder='printenv > /tmp/foo' --git-no-pbuilder
> >
> > and check if it has all the needed environment variables? If I do this I
> > do find DBUS_SESSION_BUS_ADDRESS in there as well as several gpg related
> > ones (like GPG_AGENT_INFO) and looking at the code we don't clear the
> > env, we either extend it or leave it untouched (by passing None).
> 
> yes, i see DBUS_SESSION_BUS_ADDRESS in there too.  hmmmm.
> 
> > So are we sure it's environment variable related or maybe something else?
> >
> > Another possibility would be to use
> >
> >     strace -f -o /tmp/bla.log -s2048 dpkg-buildpackage
> >
> > as builder so we can maybe figure what's going wrong (i.e. if it's not
> > possible to open the dbus socket)?
> 
> huh, this actually worked to build the package just fine.
> 
> But it helped me to narrow things down!  it looks like
> --git-builder=debuild is what's causing the stripping, and when
> buildpackage.builder is the empty string and debuild is available in the
> $PATH, it prefers debuild to dpkg-buildpackage (which is probably
> reasonable).
> 
> I'll go hassle the debuild folks now :)
> 
> Thanks for helping me debug,

Thank you for your explanation!
Cheers,
 -- Guido