[git-buildpackage] git-mock

[Guido Günther]

On Wed, Jan 28, 2015 at 06:06:58PM +0100, Tzafrir Cohen wrote:
> Hi,
> 
> [My messages to the list seem to get rejected. Probably due to
> misconfiguration on my mail server]
> 
> On Sat, Jan 24, 2015 at 11:17:15PM +0100, Guido Günther wrote:
> > On Tue, Dec 30, 2014 at 11:16:37AM +0100, Tzafrir Cohen wrote:
> > > On Sun, Dec 28, 2014 at 02:27:51PM +0100, Tzafrir Cohen wrote:
> > > > On Sun, Dec 28, 2014 at 01:22:27PM +0100, Guido Günther wrote:
> > > > 
> > > > > ======================================================================
> > > > > ERROR: test suite for <class 'tests.component.rpm.test_pq_rpm.TestPqRpm'>
> > > > 
> > > > Speaking of tests, I think that the following should also be included in
> > > > the branch (unless I missed it elsewhere):
> > > > 
> > > >   http://git.tzafrir.org.il/cgit/git-buildpackage.git/commit/?id=b2d8fa3bdb750ddf974cb605de4e5f0c9b4281cb
> > > > 
> > > > That repo also has a brute-force rebase of buildpackage-rpm on top of
> > > > 0.6.22 (just that command. Others are still missing).
> > > 
> > > On top of that I now have an initial version of --git-mock - using mock
> > > as a chroot builder for rpm packages. I basically copied the way
> > > pbuilder is used (created a separate git-mock and used it as a builder).
> > > Mock is already installed by default with its own permission elavtion
> > > handler.
> > 
> > The tests on buildpackage-rpm branch at
> > git://git.tzafrir.org.il/git/git-buildpackage.git fail for me like:
> > 
> > ======================================================================
> > ERROR: Basic test for apply action
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
> >     self.test(*self.arg)
> >   File "/var/scratch/src/git-buildpackage/git-buildpackage/tests/component/rpm/test_pq_rpm.py", line 243, in test_apply
> >     eq_(mock_pq(['apply', tmp_patch.name]), 0)
> >   File "/var/scratch/src/git-buildpackage/git-buildpackage/tests/component/rpm/test_pq_rpm.py", line 36, in mock_pq
> >     return pq(['arg0'] + args)
> >   File "/var/scratch/src/git-buildpackage/git-buildpackage/gbp/scripts/pq_rpm.py", line 477, in main
> >     apply_single_patch(repo, current, patch, fallback_author=None)
> > TypeError: apply_single_patch() takes exactly 5 arguments (4 given)
> > -------------------- >> begin captured logging << --------------------
> > gbp: error: No patch name given.
> > --------------------- >> end captured logging << ---------------------
> 
> Fixed now.
> 
> d8fc4b0b500c3905f7866b42415aa95863ee509e pq_rpm: add 'options' to some functions

Tests pass now, thank!
 -- Guido